Skip to content

Figure.meca: Refactor the two tests for offsetting beachballs#2572

Merged
seisman merged 3 commits intomainfrom
meca/refactor-offset
Jun 12, 2023
Merged

Figure.meca: Refactor the two tests for offsetting beachballs#2572
seisman merged 3 commits intomainfrom
meca/refactor-offset

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jun 12, 2023

Followup PR of #2533 and #2565.

Changes in this PR:

  • Rename test test_meca_dict_offset to test_meca_offset
  • Refactor test_meca_offset so that it can be reused
  • Merge test_meca_dict_offset_in_dict into test_meca_offset

@seisman seisman added the maintenance Boring but important stuff for the core devs label Jun 12, 2023
@seisman seisman added this to the 0.10.0 milestone Jun 12, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Jun 12, 2023
@github-actions
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
renamed pygmt/tests/baseline/test_meca_dict_offset.png -> pygmt/tests/baseline/test_meca_offset.png

Image diff(s)

Details

Added images

Modified images

Path Old New

Report last updated at commit e89e5e8

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jun 12, 2023
@yvonnefroehlich yvonnefroehlich changed the title Figure.meca: Refactor the two tests for offsetting beachablls Figure.meca: Refactor the two tests for offsetting beachballs Jun 12, 2023
@seisman seisman merged commit 999ac29 into main Jun 12, 2023
@seisman seisman deleted the meca/refactor-offset branch June 12, 2023 23:37
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants