Skip to content

Add Jing-Hui to AUTHORS.md#2430

Merged
seisman merged 3 commits intoGenericMappingTools:mainfrom
jhtong33:add_author
Mar 16, 2023
Merged

Add Jing-Hui to AUTHORS.md#2430
seisman merged 3 commits intoGenericMappingTools:mainfrom
jhtong33:add_author

Conversation

@jhtong33
Copy link
Contributor

Description of proposed changes

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JingHuiTong! Would you also like to be added to @GenericMappingTools/pygmt-contributors, similar to @yvonnefroehlich? That way you can add branches directly to https://github.com/GenericMappingTools/pygmt instead of using your own fork.

We can also add you to our Slack channel if you'd like, though we only use it once in a while, most of our communication will still be through GitHub.

AUTHORS.md Outdated
* [William Schlitzer](https://github.com/willschlitzer) | [0000-0002-5843-2282](https://orcid.org/0000-0002-5843-2282) | Unaffiliated
* [Yohai Magen](https://github.com/yohaimagen) | [0000-0002-4892-4013](https://orcid.org/0000-0002-4892-4013) | Tel Aviv University, Israel
* [Yvonne Fröhlich](https://github.com/yvonnefroehlich) | [0000-0002-8566-0619](https://orcid.org/0000-0002-8566-0619) | Karlsruhe Institute of Technology, Germany
* [Jing-Hui Tong](https://github.com/JingHuiTong) | [0009-0002-7195-3071](https://orcid.org/0009-0002-7195-3071) | National Taiwan Normal University, Taiwan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move this to line 16 in this file? We'd like to keep the list in alphabetical order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Wei Ji, I would like to be added to @GenericMappingTools/pygmt-contributors!

Copy link
Member

@weiji14 weiji14 Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let me check with the others first. @GenericMappingTools/pygmt-maintainers, ok with adding @JingHuiTong to the contributors team?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can't seem to add people to the team... Maybe because I'm not a GMT org admin? @seisman or @maxrjones, could you trying adding her please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can't seem to add people to the team... Maybe because I'm not a GMT org admin? @seisman or @maxrjones, could you trying adding her please?

Invitation sent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the team @JingHuiTong! Super excited about your involvement 🎉 thanks for all your contributions so far!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @JingHuiTong 🎉. Great to see the contributors team growing 🚀.

@seisman seisman changed the title add Jing-Hui to author.md Add Jing-Hui to AUTHORS.md Mar 16, 2023
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 16, 2023
@seisman seisman added this to the 0.9.0 milestone Mar 16, 2023
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Mar 16, 2023
@seisman seisman merged commit 548bcf0 into GenericMappingTools:main Mar 16, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 16, 2023
@jhtong33 jhtong33 deleted the add_author branch July 18, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants