Figure.timestamp: Let the 'text' parameter work for GMT<=6.4.0 and raise a warning for long text#2425
Merged
Figure.timestamp: Let the 'text' parameter work for GMT<=6.4.0 and raise a warning for long text#2425
Conversation
…ise a warning for long text
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded images
Modified images
Report last updated at commit 351ea75 |
michaelgrund
approved these changes
Mar 15, 2023
michaelgrund
approved these changes
Mar 15, 2023
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Changes in this PR:
-U's+tmodifier was added Let -U take +ttext to override time stamp gmt#7127, so thetextparameter doesn't work for GMT<=6.4.0. This PR implements the same feature for GMT<=6.4.0 by overrriding thetimefmtparameter that will be passed toFORMAT_TIME_STAMP. Now, thetextparameter works the same for any GMT versions.textparameter will be truncated to 64 characters if its length exceeds 64. NowFigure.timestamp()raise a warning instead of an exception when getting a too longtextargument.textparameter.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version