Skip to content

Add inline example for grdview#2381

Merged
seisman merged 9 commits intomainfrom
inline-example/grdview
Mar 23, 2023
Merged

Add inline example for grdview#2381
seisman merged 9 commits intomainfrom
inline-example/grdview

Conversation

@willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented Feb 22, 2023

Addresses #1957

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Feb 22, 2023
@willschlitzer willschlitzer added this to the 0.9.0 milestone Feb 22, 2023
@willschlitzer willschlitzer self-assigned this Feb 22, 2023
@willschlitzer willschlitzer mentioned this pull request Feb 22, 2023
Open
22 tasks
michaelgrund
michaelgrund reviewed Feb 22, 2023
View reviewed changes
yvonnefroehlich
yvonnefroehlich reviewed Feb 22, 2023
View reviewed changes
@maxrjones maxrjones mentioned this pull request Mar 14, 2023
Closed
36 tasks
@seisman seisman removed the skip-changelog Skip adding Pull Request to changelog label Mar 15, 2023
@seisman
Copy link
Member

seisman commented Mar 16, 2023

Ping @willschlitzer to see if you have time to finish this PR before the v0.9.0 release.

@seisman @michaelgrund @yvonnefroehlich
Apply suggestions from code review
e2ff1a4 
Co-authored-by: Michael Grund <23025878+michaelgrund@users.noreply.github.com>
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman
Copy link
Member

seisman commented Mar 19, 2023

It's likely that Will is busy recently, so I'm taking over this PR to make sure that we can have it done before v0.9.0.

@seisman seisman added the needs review This PR has higher priority and needs review. label Mar 19, 2023
yvonnefroehlich
yvonnefroehlich reviewed Mar 19, 2023
View reviewed changes
@seisman @yvonnefroehlich
Apply suggestions from code review
2691d51 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
yvonnefroehlich
yvonnefroehlich reviewed Mar 19, 2023
View reviewed changes
@willschlitzer
Copy link
Contributor Author

willschlitzer commented Mar 19, 2023

Hey, sorry that I've been MIA; I should have time to work on things this week, but no problem with @seisman making changes/approving things.

seisman
seisman reviewed Mar 20, 2023
View reviewed changes
@seisman
Copy link
Member

seisman commented Mar 20, 2023

Hey, sorry that I've been MIA; I should have time to work on things this week, but no problem with @seisman making changes/approving things.

Don't worry. Welcome back.

yvonnefroehlich
yvonnefroehlich reviewed Mar 21, 2023
View reviewed changes
@seisman @yvonnefroehlich
Update pygmt/src/grdview.py
e718c1c 
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 22, 2023
yvonnefroehlich
yvonnefroehlich reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Just wondering whether we should decide about starting comments with either upper-case letters or with lower-case letters, across all examples? I have a little preference towards upper-case letters, but I am also totally fine with the lower-case option 🙂.

@seisman
Copy link
Member

seisman commented Mar 23, 2023

Hm. Just wondering whether we should decide about starting comments with either upper-case letters or with lower-case letters, across all examples? I have a little preference towards upper-case letters, but I am also totally fine with the lower-case option slightly_smiling_face.

Either is fine to me.

@seisman seisman merged commit 818dfa5 into main Mar 23, 2023
@seisman seisman deleted the inline-example/grdview branch March 23, 2023 02:39
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelgrund michaelgrund michaelgrund left review comments

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

@seisman seisman seisman approved these changes

Assignees

@willschlitzer willschlitzer

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@willschlitzer @seisman @michaelgrund @yvonnefroehlich