Skip to content

Update baseline image for test test_grdview_drapegrid_dataarray#2068

Merged
weiji14 merged 10 commits intomainfrom
update-test_grdview_drapegrid_dataarray.png
Jul 2, 2023
Merged

Update baseline image for test test_grdview_drapegrid_dataarray#2068
weiji14 merged 10 commits intomainfrom
update-test_grdview_drapegrid_dataarray.png

Conversation

@seisman
Copy link
Member

@seisman seisman commented Aug 20, 2022

See #2062 (comment) for context.

The test fails because the grid registration and gtype information stored in the GMT accessor are lost after grid operation (drapegrid = 1.1 * xrgrid). This PR fixes the issue by manually assign the grid registration and gtype:

    drapegrid.gmt.registration = xrgrid.gmt.registration
    drapegrid.gmt.gtype = xrgrid.gmt.gtype

Closes #2062.

@seisman seisman marked this pull request as ready for review August 20, 2022 14:00
@seisman seisman changed the title Update the baseline image for test_grdview_drapegrid_dataarray.png WIP: Update the baseline image for test_grdview_drapegrid_dataarray.png Aug 20, 2022
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Aug 28, 2022
@seisman seisman added this to the 0.9.0 milestone Dec 20, 2022
@seisman seisman modified the milestones: 0.9.0, 0.10.0 Mar 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2023

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_grdview_drapegrid_dataarray.png

Image diff(s)

Details

Added images

Modified images

Path Old New
test_grdview_drapegrid_dataarray.png

Report last updated at commit b75625d

@GenericMappingTools GenericMappingTools deleted a comment from github-actions bot Jun 27, 2023
@seisman seisman changed the title WIP: Update the baseline image for test_grdview_drapegrid_dataarray.png Update baseline image for test test_grdview_drapegrid_dataarray Jun 28, 2023
@seisman
Copy link
Member Author

seisman commented Jun 28, 2023

/test-gmt-dev

@seisman seisman added the needs review This PR has higher priority and needs review. label Jun 28, 2023
@seisman seisman requested a review from a team July 2, 2023 10:27
@weiji14 weiji14 merged commit e98efe1 into main Jul 2, 2023
@weiji14 weiji14 deleted the update-test_grdview_drapegrid_dataarray.png branch July 2, 2023 21:42
@weiji14 weiji14 removed the needs review This PR has higher priority and needs review. label Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows test failures for test_accessor_sliced_datacube and test_grdview_drapegrid_dataarray

2 participants