Skip to content

Update GMT-6.4 baseline image for test_plot_shapefile (#1888)#1897

Merged
seisman merged 1 commit intogmt-6.4from
fix-test_plot_shapefile
Apr 30, 2022
Merged

Update GMT-6.4 baseline image for test_plot_shapefile (#1888)#1897
seisman merged 1 commit intogmt-6.4from
fix-test_plot_shapefile

Conversation

@seisman
Copy link
Member

@seisman seisman commented Apr 25, 2022

Description of proposed changes

The test test_plot_shapefile fails because the line width is slightly different for GMT 6.3 and 6.4. It's more obvious to see why it differs if we add the frames by setting frame=True.

Here are the two baseline images:

GMT 6.3 GMT 6.4
line-6 3 0 line-6 4 0

Apparently, in GMT 6.3, the shapefile RidgeTest.shp is plotted as a Cartesian dataset, while in GMT 6.4, it's plotted as a geographic dataset. The change is likely made in GenericMappingTools/gmt#6057.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 25, 2022
@seisman seisman added this to the 0.7.0 milestone Apr 25, 2022
@seisman seisman mentioned this pull request Apr 25, 2022
Closed
69 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_basemap_compass.png
modified pygmt/tests/baseline/test_basemap_polar.png
modified pygmt/tests/baseline/test_basemap_utm_projection.png
modified pygmt/tests/baseline/test_config_format_date_map.png
modified pygmt/tests/baseline/test_contour_vec.png
modified pygmt/tests/baseline/test_geopandas_plot3d_default_cube.png
modified pygmt/tests/baseline/test_geopandas_plot3d_non_default_circle.png
modified pygmt/tests/baseline/test_grdcontour.png
modified pygmt/tests/baseline/test_grdcontour_labels.png
modified pygmt/tests/baseline/test_grdview_on_a_plane_with_colored_frontal_facade.png
modified pygmt/tests/baseline/test_grdview_with_cmap_for_image_plot.png
modified pygmt/tests/baseline/test_grdview_with_perspective.png
modified pygmt/tests/baseline/test_grdview_with_perspective_and_zaxis_frame.png
modified pygmt/tests/baseline/test_image.png
modified pygmt/tests/baseline/test_legend_default_position.png
modified pygmt/tests/baseline/test_legend_entries.png
modified pygmt/tests/baseline/test_legend_position.png
modified pygmt/tests/baseline/test_logo.png
modified pygmt/tests/baseline/test_makecpt_continuous.png
modified pygmt/tests/baseline/test_makecpt_plot_colorbar_scaled_with_series.png
modified pygmt/tests/baseline/test_makecpt_reverse_color_and_zsign.png
modified pygmt/tests/baseline/test_makecpt_reverse_color_only.png
modified pygmt/tests/baseline/test_makecpt_truncated_zlow_zhigh.png
modified pygmt/tests/baseline/test_meca_spec_1d_array.png
modified pygmt/tests/baseline/test_meca_spec_dataframe.png
modified pygmt/tests/baseline/test_plot3d_colors_sizes_proj.png
modified pygmt/tests/baseline/test_plot3d_matrix.png
modified pygmt/tests/baseline/test_plot3d_ogrgmt_file_multipoint_default_style.png
modified pygmt/tests/baseline/test_plot3d_ogrgmt_file_multipoint_non_default_style.png
modified pygmt/tests/baseline/test_plot3d_projection.png
modified pygmt/tests/baseline/test_plot3d_red_circles_zscale.png
modified pygmt/tests/baseline/test_plot_colors_sizes_proj.png
modified pygmt/tests/baseline/test_plot_matrix.png
modified pygmt/tests/baseline/test_plot_shapefile.png
modified pygmt/tests/baseline/test_rose_2d_array_multiple.png
modified pygmt/tests/baseline/test_rose_2d_array_single.png
modified pygmt/tests/baseline/test_solar_set_terminator_datetime.png
modified pygmt/tests/baseline/test_solar_terminators.png
modified pygmt/tests/baseline/test_text_fill.png
modified pygmt/tests/baseline/test_text_justify_bottom_right_and_top_left.png
modified pygmt/tests/baseline/test_text_multiple_lines_of_text.png
modified pygmt/tests/baseline/test_text_position.png
modified pygmt/tests/baseline/test_text_position_offset_with_line.png
modified pygmt/tests/baseline/test_text_single_line_of_text.png
modified pygmt/tests/baseline/test_velo_numpy_array_numeric_only.png
modified pygmt/tests/baseline/test_velo_pandas_dataframe.png
modified pygmt/tests/baseline/test_wiggle.png

Image diff(s)

Details

Added images

Modified images

Path Old New
test_basemap_compass.png
test_basemap_polar.png
test_basemap_utm_projection.png
test_config_format_date_map.png
test_contour_vec.png
test_geopandas_plot3d_default_cube.png
test_geopandas_plot3d_non_default_circle.png
test_grdcontour.png
test_grdcontour_labels.png
test_grdview_on_a_plane_with_colored_frontal_facade.png
test_grdview_with_cmap_for_image_plot.png
test_grdview_with_perspective.png
test_grdview_with_perspective_and_zaxis_frame.png
test_image.png
test_legend_default_position.png
test_legend_entries.png
test_legend_position.png
test_logo.png
test_makecpt_continuous.png
test_makecpt_plot_colorbar_scaled_with_series.png
test_makecpt_reverse_color_and_zsign.png
test_makecpt_reverse_color_only.png
test_makecpt_truncated_zlow_zhigh.png
test_meca_spec_1d_array.png
test_meca_spec_dataframe.png
test_plot3d_colors_sizes_proj.png
test_plot3d_matrix.png
test_plot3d_ogrgmt_file_multipoint_default_style.png
test_plot3d_ogrgmt_file_multipoint_non_default_style.png
test_plot3d_projection.png
test_plot3d_red_circles_zscale.png
test_plot_colors_sizes_proj.png
test_plot_matrix.png
test_plot_shapefile.png
test_rose_2d_array_multiple.png
test_rose_2d_array_single.png
test_solar_set_terminator_datetime.png
test_solar_terminators.png
test_text_fill.png
test_text_justify_bottom_right_and_top_left.png
test_text_multiple_lines_of_text.png
test_text_position.png
test_text_position_offset_with_line.png
test_text_single_line_of_text.png
test_velo_numpy_array_numeric_only.png
test_velo_pandas_dataframe.png
test_wiggle.png

Report last updated at commit 65c9d46

@seisman seisman merged commit d2cc6fb into gmt-6.4 Apr 30, 2022
@seisman seisman deleted the fix-test_plot_shapefile branch April 30, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.7.0

Development

Successfully merging this pull request may close these issues.

1 participant

@seisman