Document interpolation restriction for grdtrack xarray input#1587
Document interpolation restriction for grdtrack xarray input#1587
Conversation
|
/format |
weiji14
left a comment
There was a problem hiding this comment.
Feels like we need a unit test for this, checking the output of grdtrack when using a NetCDF file (default to bicubic) and xarray.DataArray input (default to bilinear).
| Note: Only bilinear or nearest-neighbor interpolation are currently | ||
| available when ``grid`` is an :class:`xarray.DataArray`. |
There was a problem hiding this comment.
Does b-spline work for xr.DataArray inputs?
There was a problem hiding this comment.
No, it will return bilinear interpolation results.
I'm not sure I follow what should be added. |
Ah ok, forgot that we had those comprehensive tests. Just ignore what I said then. And actually, it looks like the change upstream in GenericMappingTools/gmt#5283 will be reverted according to GenericMappingTools/gmt#5893 (comment), so maybe we don't need this PR anymore? |
Description of proposed changes
This PR documents the workaround to #1309 implemented in GenericMappingTools/gmt#5283.
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version