-
Notifications
You must be signed in to change notification settings - Fork 243
Closed
Labels
documentationImprovements or additions to documentationImprovements or additions to documentation
Milestone
Description
Lines 640 to 641 in cd8dcef
| git push | |
| dvc push |
The contributing guides tell that users should run git push then dvc push.
The problem is, when someone pushes changes to github (git push), the dvc-diff.yml workflow will be triggered immediately.
After the workflow starts, it will take about 45 seconds to set up everything and starts to pull images from DagsHub (i.e., running the dvc pull command). So it means that users must run dvc push quickly after running git push, otherwise the dvc-diff.yml workflow will fail.
From the commit message of e30c708, it seems that the order of dvc push and git push doesn't matter. I think running dvc push before git push is a better and safer option.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentation