-
Notifications
You must be signed in to change notification settings - Fork 243
Description
Description of the desired feature
Continuing on from #1276, there are some parameters in upstream GMT at https://docs.generic-mapping-tools.org/6.2/grdfill.html which are still missing in PyGMT at https://www.pygmt.org/v0.4.0/api/generated/pygmt.grdfill.html. Your task is to fill them in!
Current state 📝
Lines 21 to 22 in d90b3fc
| R="region", | |
| V="verbose", |
Lines 54 to 55 in d90b3fc
| {R} | |
| {V} |
Desired state ✨
You'll need to change two parts of the grdfill.py module like so:
R="region",
V="verbose",
f="coltypes", {R}
{V}
{f}How to make the change 🧐
- First, read up our contributing guidelines at https://www.pygmt.org/v0.4.0/contributing.html#editing-the-documentation
- Leave a comment below, stating that you will tackle this issue. We will assign you to this issue and you can then start working on it.
- To edit the
grdfillmodule's docstring, go to https://github.com/GenericMappingTools/pygmt/edit/master/pygmt/src/grdfill.py and add in the new docstring! - Submit a pull request, and be sure to fill it up with as much detail as possible.
Tip: See the Pull Request at #1343 for an example of how a common alias can be added.
Stretch goals 🚀
Suggest a good long alias name for the grdfill -N parameter, and add it to the Pull Request!
🥳 Good luck, and let us know if you need any help :)
Are you willing to help implement and maintain this feature? Happy to review someone's Pull Request on it.