Skip to content

Some rose tests are wrong #1315

@seisman

Description

@seisman

Description of the problem

The issue was first reported in GenericMappingTools/gmt#5289 (comment).

The GMT rose module expects length and azimuth.

The sample data @fractures_06.txt contains azimuth,length. When writing the load_fractures_compilation function, we decided to return length,azimuth, rather than azimuth,length, so that the rose tests don't need to swap the columns. However, when writing the tests, we incorrectly used incols=[1, 0], which swaps the columns to azimuth,length again.

The baseline images are correct because the -i option doesn't work as expected due to an upstream bug (fixed in GenericMappingTools/gmt#5289). Thus, after the fix, the incols=[1, 0] parameter is no longer needed.

We need to fix these rose tests after bumping to GMT 6.2.0.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingmaintenanceBoring but important stuff for the core devs

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions