Let psconvert -N+kfill set alternate fade fill#7972
Merged
PaulWessel merged 6 commits intomasterfrom Oct 24, 2023
Merged
Conversation
Movie allows two fill settings that are passed to psconvert when building the rasters WIth -G one can fill the bounding box with selected color before other things are painted With -K (and -E) one can specify what the terminal fade color should be [black]. Unfortunately, psconvert only had -N+g to accept the backgorund fill and the fade color was passed the same way via -N+g, resulting in two different +g<color> modifier passed to psconvert, which then used the last one given. THis PR adds +kfadefill to -N and updates movie to pass that modifier to psconvert when the fading color is explicitly set.
joa-quim
approved these changes
Oct 24, 2023
Member
|
I see now that the default color for the fade is black while the canvas color is white (no fill). Wouldn't be better to have the same default color? I know that it is not important. |
Member
Author
|
If they both were white or black, you would fade from white to white or black to black. Since -G changes background from white it makes most sense to me to default fade from black if -K or -E is used. |
Member
Mmm, yes, you will see the content of the last frame dissapear (to white or black). But, I am ok with your solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7593 for some background. movie allows two fill settings that are passed to psconvert when building the rasters:
Unfortunately, psconvert only had -N+g to accept the background fill and the fade colour was passed from movie the same way via -N+g, resulting in two different +gcolor modifier passed to psconvert, which then of course used just the last one given. Thus, fade was always black.
This PR does several things:
psconvertoptionsin figureCloses #7593
ffmpeg3.mp4