Skip to content

Let pslegend -D+w accept a percentage relative to map width#7909

Merged
Esteban82 merged 2 commits intomasterfrom
legend-percent-width
Oct 17, 2023
Merged

Let pslegend -D+w accept a percentage relative to map width#7909
Esteban82 merged 2 commits intomasterfrom
legend-percent-width

Conversation

@PaulWessel
Copy link
Member

@PaulWessel PaulWessel commented Oct 15, 2023

Similar to psscale, allow processing of things like +w80%. This PR implements this via a new gmt function gmt_rectangle_dimension that does the parsing, hence the PR involves psscale as well as some library and include files.

@Esteban82, All tests pass as before, but I have not tested this specifically with legend. Please give it a try. +w90% will set width to 90% of map width, while +w90%/30% will fix height at 30% of the legend width (not map width).

@PaulWessel
Let pslegend -D+w accept a percentage relative to map width
db98bd9 
Similar to psscale, allow processing of things like +w80%.  This PR implements this via a new gmt function that does the parsing, hence the PR involves psscale as well as some library and include files.
@PaulWessel PaulWessel added the enhancement Improving an existing feature label Oct 15, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Oct 15, 2023
@PaulWessel PaulWessel requested a review from Esteban82 October 15, 2023 11:01
@PaulWessel PaulWessel self-assigned this Oct 15, 2023
@Esteban82
Copy link
Member

Esteban82 commented Oct 15, 2023

Thanks Paul!!

I'm affraid that is not working. I try the script below and I didn't get any legend and this message:
legend [ERROR]: Must specify -D...+w<width> if more than one symbol column (N = 5)

Full script

gmt begin GMT_earth_mask png
	gmt set GMT_THEME cookbook GMT_DATA_SERVER candidate
	gmt makecpt -Clightblue,burlywood,blue,red,white -T-0.5/4.5/1 -N
	gmt grdimage @earth_mask_05m -JQ0/15c
	gmt legend -DJBC+w90%+o0/0.05c -F+p1p <<- EOF
	N 5
	S - s 0.5c lightblue 0.25p - Ocean [0]
	S - s 0.5c burlywood 0.25p - Land [1]
	S - s 0.5c blue 0.25p - Lake [2]
	S - s 0.5c red 0.25p - Island [3]
	S - s 0.5c white 0.25p - Pond [4]
	EOF
gmt end

If a remove the line N 5, them it works but it is not the legend that I want.

GMT_earth_mask

@PaulWessel
Copy link
Member Author

PaulWessel commented Oct 15, 2023

Shit, in modern mode the command has no -R -J and when that check comes it has not yet set them from hidden file... I will check. If you just try a classic case it should work.

@PaulWessel
Copy link
Member Author

PaulWessel commented Oct 15, 2023

Just a dump 1 line error. Now rows I think (your script runs for me)

Esteban82
Esteban82 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Esteban82 Esteban82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works.

@Esteban82 Esteban82 merged commit c15b21d into master Oct 17, 2023
@Esteban82 Esteban82 deleted the legend-percent-width branch October 17, 2023 02:37
@Esteban82 Esteban82 added the add-changelog Add PR to the changelog label Oct 17, 2023
@Esteban82
Copy link
Member

Esteban82 commented Oct 17, 2023

I took the liberty of adding the label "add-changelog".

@Esteban82 Esteban82 mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Esteban82 Esteban82 Esteban82 approved these changes

Assignees

@PaulWessel PaulWessel

Labels

add-changelog Add PR to the changelog enhancement Improving an existing feature

Projects

None yet

Milestone

6.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulWessel @Esteban82