Skip to content

psconvert should ignore writing world file if geotiff output is requested#7865

Merged
PaulWessel merged 2 commits intomasterfrom
no-world-file
Oct 4, 2023
Merged

psconvert should ignore writing world file if geotiff output is requested#7865
PaulWessel merged 2 commits intomasterfrom
no-world-file

Conversation

@PaulWessel
Copy link
Member

@PaulWessel PaulWessel commented Oct 4, 2023

See #7844 for discussion. Closes #7844. Note to @joa-quim : In messages that says

...the Proj4 command...

should that be PROJ or are these things still called Proj4 even though we are at Proj9? Let me know if we should update such language in source and rst (separate from this PR). I just added an extra check that we only do the world_file output if Ctrl->W.warp (-W+g) is not set. See right, no?

@PaulWessel
Ignore writing world file if geotiff output is requested
c7a3af6 
See #7844 for discussion.  Closes #7844. Note to @joa-quim : In messages that says

...the Proj4 command...

should that be PROJ or are these things still called proj4 even though we are at proj9?
@PaulWessel PaulWessel added the bug Something isn't working label Oct 4, 2023
@PaulWessel PaulWessel added this to the 6.5.0 milestone Oct 4, 2023
@PaulWessel PaulWessel requested review from joa-quim and seisman October 4, 2023 09:21
@PaulWessel PaulWessel self-assigned this Oct 4, 2023
@joa-quim
Copy link
Member

joa-quim commented Oct 4, 2023 •
edited
Loading

Does it work? Because when it calls gdal_translate it's not impossible that a world fine is needed.

The Proj4 vs PROJ. There is only proj4 , the name, or PROJ (and don't pay attention to the capitalization. I don't know what is the correct way). No proj5,6,7,8,9. Functions variables, including in official PostGIS docs are still called proj4... The guys that took care of proj development decided to drop the 4 from the name at around proj v6, but there are still tons of proj4 references in the internet. So, in summary, for my taste, I still prefer to call the proj4 strings as is still used in, for example,
https://spatialreference.org/ref/epsg/4326/

@seisman
Copy link
Member

seisman commented Oct 4, 2023

Does it work? Because when it calls gdal_translate it's not impossible that a world fine is needed.

You're right. It needs the world file to produce the GeoTIFF file. It means we need to delete the world file after calling gdal_translate.

@PaulWessel
Copy link
Member Author

PaulWessel commented Oct 4, 2023

OK, I will fix that. Will leave proj4 of course.

@PaulWessel
Update psconvert.c
3d267b9 
Keep old world_file name so it can be deleted.
@PaulWessel
Copy link
Member Author

PaulWessel commented Oct 4, 2023

How about this one? Had to duplicate world_file since you recycled it for something else and it got lost.

@PaulWessel PaulWessel merged commit 623a189 into master Oct 4, 2023
@PaulWessel PaulWessel deleted the no-world-file branch October 4, 2023 11:49
@weiji14 weiji14 mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seisman seisman seisman approved these changes

@joa-quim joa-quim Awaiting requested review from joa-quim

Assignees

@PaulWessel PaulWessel

Labels

bug Something isn't working

Projects

None yet

Milestone

6.5.0

Development

Successfully merging this pull request may close these issues.

Incorrect world file name when generating GeoTIFF file

3 participants

@PaulWessel @joa-quim @seisman