Use MAP_SYMBOL_PEN_SCALE instead of MAP_STROKE_WIDTH#7822
Conversation
See #7788 for discussion at end. Note the internal variable is map_stroke_width. wo questions: 1. Rename map_stroke_width to map_stroke_factor 2. Consider SCALE instead of FACTOR?
|
I'm fine with FACTOR. |
|
Can we drop the |
It surely is long, give you that. @remkos used to be the master of brevity. Anything shorter, Remko? |
It's true that this would be getting long. But Look @joa-quim : I just saved 3 characters 😄. It is shorter than many of the others that we have, e.g.: |
|
I prefer |
|
Do we really need the new default MAP_SYMBOL_STROKE_FACTOR? It's easy to change the scale via the -W option so I feel the new default will be rarely used. |
|
@seisman : You can set the pen width with -W, but that would then apply to any symbol size. The thing is that Paul wanted to ensure that if someone did not supply -W, some pen width would be set automatically. For example But in any case you are correct: it would be a barely used setting. |
|
I aded WIP until we have a solution. Just so we are on the same page. Unless MAP_SYMBOL_STROKE_FACTOR is set to 0, we do
So the pen thickness does not enter I think, @seisman ? The whole point was to scale the pen to a fraction of symbol size. Adding -W4p makes all symbols fat. |
That makes sense to me now.
My first impression about |
|
Must say MAP_SYMBOL_PEN_SCALE is not bad: Avoids cardiac arrests and shaves a few letters. |
Well, I think this obscure default [15%] wont confuse people if they read the documentation about it and why it is there. I have a linear size -> pen thickness scheme but am I convinced there will be some users who thinks the 15% is too big or too small. Those guys can use the setting rather than "it cannot be done". The docs list the four symbols that this default pertains to: x, y, +, -. |
|
I agree: RTFM. |
See #7788 for discussion at end. Note the internal variable is map_stroke_width. Two questions:
Not sure what is best but will go with the flow of comments. Closes #7788.