Add option to grdpaste to only report the "pasting" side.#7368
Merged
Add option to grdpaste to only report the "pasting" side.#7368
Conversation
PaulWessel
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem this PR tries to address is that
grdpastedoes not works for externals that pass in GMTgrid objects. That is so because those structs already have the grid arrays with normal (or zero) padding but thegrdpaste.cdoes quite some trickery with the pads to read the A and B grids directly on their final position in output array. So, the best is really to re-implement the matrix pasting in Julia or Matlab, which is a simple operation. But for that we must know how-to-paste and that's where the info returned by the new -S is important.