Do ternary duplication if input is read-only#7172
Merged
PaulWessel merged 2 commits intomasterfrom Dec 25, 2022
Merged
Conversation
Since the input to ternary may be read-only data we do not want ternary to change it in the calling environbment. This PR does the duplication inside ternary
seisman
approved these changes
Dec 25, 2022
Member
Author
|
The PyGMT team may wish to check what other modules modify input. I do not think we will rewrite all modules to internally do this though, in that case simpler to pass the DUPLICATE flag. |
This was referenced Dec 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pyGMT post for discussion.
@seisman, please see if this works as expected - I am of for Xmas dinner...