Clarify what happens in gravfft with NaNs#6937
Merged
PaulWessel merged 2 commits intomasterfrom Aug 7, 2022
Merged
Conversation
Because residual grids with NaNs in areas of no data are common in isostatic studies, we allow gravfft to handle such grids rather than having to use grdmath DENAN. This PR: 1. Replaces NaNs in the 1-2 input grids with zeros 2. WIth -Vl we report the number of NaNs as well 3. The documentation now has a new section that discussion what happens with the NaN grids.
This is useful when the +s correction is not appropriate or the density is variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because residual grids with NaNs in areas of no data are common in isostatic studies, we allow gravfft to handle such grids rather than having to use grdmath DENAN. This PR: