Let batch -D drop the mandatory moving of product files#6933
Merged
PaulWessel merged 3 commits intomasterfrom Aug 3, 2022
Merged
Let batch -D drop the mandatory moving of product files#6933PaulWessel merged 3 commits intomasterfrom
PaulWessel merged 3 commits intomasterfrom
Conversation
See #6932 for discussion. This PR implements a -D option that stops any copying. This solution does not preempt further consideration of the other suggestion which is to generalize the naming of product files via a -Ftemplate option.
Member
|
It would be possible that -D should be used with -Q? If I don't use -Q, I think that all files are deleted. It could be possible? |
Member
Author
|
I have also implemented -F and testing it. The -Q should strictly be for debugging. With -D (this PR) and -F (next PR coming once this is approved) we have full control:
With these changes I can write batch jobs that produces parameter files like this: You will note I have introduced a new parameter called BATCH_DIR which basically replaces the old use of BATCH_NAME and BATCH_NAME is now exclusively used for product naming. |
Esteban82
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6932 for discussion. This PR implements a -D option that stops any copying of batch products to the top directory. This solution does not preempt further consideration of the other suggestion which is to generalize the naming of product files via a -Ftemplate option.