Skip to content

Must erase any input grid CPT in grdmath#6914

Merged
PaulWessel merged 4 commits intomasterfrom
wipe-cpt
Jul 25, 2022
Merged

Must erase any input grid CPT in grdmath#6914
PaulWessel merged 4 commits intomasterfrom
wipe-cpt

Conversation

@PaulWessel
Copy link
Member

See #6909 for background.

This PR introduces a hidden parameters that some modules (right now just grdmath) can set to prevent a grid deriving from a remote data set to inherit (and save) the CPT name in the grid file.

Closes #6909.

@PaulWessel PaulWessel added the bug Something isn't working label Jul 25, 2022
@PaulWessel PaulWessel added this to the 6.5.0 milestone Jul 25, 2022
@PaulWessel PaulWessel self-assigned this Jul 25, 2022
@joa-quim
Copy link
Member

I think it would be better to introduce a new struct for the metadata propagation (or not) instead of that new bool ignore_remote_cpt; Otherwise for each new control a new member will have to be added to the GMTAPI_CTRL

@PaulWessel
Copy link
Member Author

OK, so a sub-structure of GMTAPI_CTRL with some name that would currently only have one bool variable?

@joa-quim
Copy link
Member

Yes.

@PaulWessel PaulWessel merged commit fff5e33 into master Jul 25, 2022
@PaulWessel PaulWessel deleted the wipe-cpt branch July 25, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When to keep or remove a grids default CPT argument

2 participants