Merged
Conversation
An interface grid is a surface that may cross zero. If so, the prisms we create should change sign across the zero threshold and for negative z we create a prism from x to 0 and for positive z we go from 0 to z. If a second surface or constant is given then we have a layer and no density changes sign. Documentation has ben updated to explain this as well adn a few comments were added elsewhere. I also added a test on the density contrast (-D cannot be 0, but variable density from grid could be zero at times and then we skip making a dummy prism).
joa-quim
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interface grid is a surface that may cross zero. If it does, the prisms we create should change sign across the zero threshold and for negative z we create a prism from x to 0 and for positive z we go from 0 to z. If a second surface or constant is given then we have a layer and no density changes sign. Documentation has been updated to explain this as well and a few comments were added elsewhere. I also added a test on the density contrast (-D cannot be 0, but variable densities from a grid could be zero at times and then we skip making a dummy prism).