Add option to get Git commit information through C API#6493
Merged
Add option to get Git commit information through C API#6493
Conversation
PaulWessel
approved these changes
Mar 28, 2022
Member
|
I'm wondering if API_BIN_VERSION is a better name here, because for public releases, it's a version string like 6.4.0 without git commit information. |
Member
|
Also need to update the API documentation https://docs.generic-mapping-tools.org/dev/devdocs/api.html#get-or-set-an-api-or-gmt-default-parameter. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds
API_GIT_COMMITto the API keywords forGMT_Get_Default, so that wrappers can more easily access the commit information for the GMT library (xref GenericMappingTools/pygmt#1838).Fixes #
Reminders