Let colorbar plot rectangles if possible#6360
Merged
PaulWessel merged 8 commits intomasterfrom Feb 23, 2022
Merged
Conversation
Because Apple Preview (and possibly others) will resample coarse PDF images, any colormap based on a discrete CPT will look very blurred and continuous. This PR lets -Np be the default if it is possible.
Member
|
@PaulWessel, should I push the test image updates to this branch? |
Member
Author
|
yes, please. I looked at CONTRIBUTING and I probably missed it but I did not find a section on how to revise plots already in dvc? |
Member
I will take a look and revise as needed in a separate PR. |
maxrjones
approved these changes
Feb 23, 2022
4 tasks
This was referenced Apr 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6350 for background. Because Apple Preview (and possibly others) will resample coarse PDF images, any colormap based on a discrete CPT will look very blurred and continuous. This PR lets -Np be the default if it is possible.
Closes #6350. Note: A handfull of PostScript plot originals will need updating due to hairline differences between the approximate images and the exact polygon boundaries.