Switch to using q instead of u for user unit#6196
Merged
PaulWessel merged 1 commit intomasterfrom Jan 6, 2022
Merged
Conversation
This change is driven by the fact u is already one of the recognized map distance units (survey foot) and hence we want a unique letter to indicate 'user unit'. Such units are used in a few places, for instance the width of a vertical bar may be specified in x-units and for columns it may separately be specified as x and/or y-units. Fixed missing usage message for teh 3-D cube symbol in psxyz and made sure all tests worked with the old 'u' before changing that to 'q' and rechecking the tests.
maxrjones
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is driven by the fact u is already one of the recognized map distance units (survey foot) and hence we want a unique letter to indicate 'user unit'. Such units are used in a few places, for instance the width of a vertical bar may be specified in x-units and for columns it may separately be specified as x and/or y-units. With coming improvements to geovector where a user quantity is needed and u is already a valid unit we need to change. Of course, the u is still handled via backwards compatibility. The new and improved unit is called q for quantity.
I also fixed missing usage message for the 3-D cube symbol in psxyz and made sure all tests worked with the old 'u' before changing them to 'q' and rechecking the tests. Also, ex43 had an outdated syntax for the bar base.