Address items 3, 4, 7 in vector proposal#6194
Merged
PaulWessel merged 2 commits intomasterfrom Jan 5, 2022
Merged
Conversation
This PR addresses those items in #6190. No tests are affected.
Member
|
Are these ok?
|
Esteban82
approved these changes
Jan 5, 2022
Member
Esteban82
left a comment
There was a problem hiding this comment.
I approve because my tests looks fine.
Member
Author
|
I think so: 100 km is a bit shorter than 2 degrees longitude at 60 N |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses these three items in #6190:
(3) Allow +z in plot and plot3 to accept components for a geovector and have them scaled to map distances. Properly compute what azimuth and length this corresponds to and plot the geovector accordingly.
(4) Disable (or give error) +z in grdvector since here we control polar vs component via -A.
(7) Accept a default scale of 1 if +z has no argument (currently this would give junk).
No tests are affected.
Some examples of geovector components calls: