Make checking for registrations more robust#6160
Merged
PaulWessel merged 1 commit intomasterfrom Dec 27, 2021
Merged
Conversation
THe gmt_set_unspecified_remote_registration function, whose job it is to determine of the pixel or gridline registration was specifically requested in a remote file name, was written before there was @earth_geoid and hence the lame check for _g or _p found _g(eoid) and returned prematurely. This PR adds the harder work of advancing past the leading dataset name and then look for _g or _p. In the process I learned I had a typo in the test gmt_data_server.txt where the earth_relief_01d_g.grd had a missing / in front of server. Just delete your test/server/gmt_data_server.txt to get the fixed file. Tests pass.
maxrjones
approved these changes
Dec 27, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to new datasets. The gmt_set_unspecified_remote_registration function, whose job it is to determine if a pixel or gridline registration version was specifically requested in a remote file name, was written before there was
@earth_geoidand hence the lame check for _g or _p easily found _g(eoid) and returned prematurely.This PR adds the harder work of advancing past the leading dataset name and then look for _g or _p in what remains.
In the process I learned I had a typo in the test gmt_data_server.txt file where the earth_relief_01d_g.grd had a missing / in front of server which meant the apimat2grd.sh test failed. Just delete your test/server/gmt_data_server.txt to get the updated file.
Tests pass.