Better handling of trailing text in sample1d output#6098
Conversation
If input records have trailing text then if there are output records at the same times then these should inherit any input trailing text .
|
My concern is that this PR could break workflows that were written with an assumption that sample1d does not output trailing text. If this is considered an enhancement, I think it would be better to set a new modifier to trigger the behavior. |
|
I did not think any of the options were suitable for a modifier for this so I added an option -E to attempt to deal with trailing text. Default thus remains the same as before. |
|
Looks good. Extra information is now preserved. Two other things:
Why are duplicate rows (on the 0th column) not allowed? Could it be?
|
|
I will look to see if we can get away with no data set to resample. Seems like that should be easy. Right now we allow n columns to be resampled and I think 0 should be allowed. |
Simple enough. Also updated the documentation
|
Now, sample1d is OK with interpolating just the time column if there are no other data columns, so @anbj can test this out. I also updated the documentation. I agree this is a useful feature (resample a set of time nodes without having to give a data column when none is needed. |
|
Super! Thank you Paul! |
See forum post for discussion. If input records have trailing text then if there are output records at the same times then these should inherit any input trailing text:
in.txt: