Let grdtrack -C also accept a fixed azimuth for all profiles#5849
Merged
PaulWessel merged 4 commits intomasterfrom Oct 6, 2021
Merged
Let grdtrack -C also accept a fixed azimuth for all profiles#5849PaulWessel merged 4 commits intomasterfrom
PaulWessel merged 4 commits intomasterfrom
Conversation
New modifier +fazimuth will ignore the orientation of the line and erect profiles in the azimuth direction instead. Test added.
maxrjones
approved these changes
Oct 6, 2021
maxrjones
reviewed
Oct 6, 2021
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
Member
Author
|
Strange, I know I changed the deviation to value in the RST... |
Member
I don't follow; the new docs reference value. |
Member
Author
|
You had some suggestions for changes that I approved and they changed +ddeviation to +d|fvalue. That is correct but I thought my changes already had that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On request by a student, new -C modifier +fazimuth will ignore the orientation of the guide line and erect profiles in the fixed azimuth direction instead. Test added (layout_fixed.sh) that works.