Merged
Conversation
When data cubes were introduced and we switched form +z to +d for setting data value (so +z can set uint for the z-axis in cubes), I allowed for backwards compatibility with +z for 2-D grids, but managed to not use the fix in the switch. Today I ran into this bug - this PR fixes it.
Also update the check of modifiers of course.
maxrjones
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When data cubes were introduced and we switched from -D modifier +z to +d for setting data names (so that +z can set the unit for the z-axis in cubes), I allowed for backwards compatibility with +z for 2-D grids, but managed to not use the fix in the relevant switch. Today I ran into this bug - this PR fixes it.