Let mapproject report rectangular region that covers an obliquely defined region#5782
Merged
PaulWessel merged 4 commits intomasterfrom Sep 19, 2021
Merged
Let mapproject report rectangular region that covers an obliquely defined region#5782PaulWessel merged 4 commits intomasterfrom
PaulWessel merged 4 commits intomasterfrom
Conversation
When we specify a projection and region via an azimuthal perspective projection or an oblique region via -Rw/s/e/n+r, it is hard to know what the corresponding rectangular region is. Here we add modifier r to -W in mapproject to report that region.
maxrjones
approved these changes
Sep 19, 2021
Member
maxrjones
left a comment
There was a problem hiding this comment.
Looks good. Note that this is available now regardless of the projection specified, do you want to limit to only oblique projections?
Member
Author
|
No, I think it is OK that it works for any projection. Even as -R0/30/0/30 -JM6i will just return 0/30/0/30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we specify an oblique region via an azimuthal perspective projection or the region via -Rw/s/e/n+r, it is hard to know what the corresponding rectangular region is, which can be very useful piece of information for advanced scripting. Here we add modifier r to -W that will report this region; use uppercase R to get a "-Rw/e/s/n" string as trailing text instead. The man page has an example of this. Here are other examples:
I do not think we need to add a specific test script for this feature since it is only reflecting internal knowledge.