Skip to content

JPEG quality and recognition of modifiers#5574

Merged
PaulWessel merged 5 commits intomasterfrom
jpeg-quality-modifier
Aug 2, 2021
Merged

JPEG quality and recognition of modifiers#5574
PaulWessel merged 5 commits intomasterfrom
jpeg-quality-modifier

Conversation

@PaulWessel
Copy link
Member

@PaulWessel PaulWessel commented Aug 1, 2021

Description of proposed changes

See #5573 for background. This PR does a few things:

  1. Adds +qquality as a modifier to psconvert -Tj so one can change the JPEG quality [Default remains at 90].
  2. Documents that the default is 90.
  3. Allows both the existing modifier +m as well as +q to be recognized when used in begin and figure (previously one could not pass +m in these modules).

All tests still pass, and this simple example shows both +m and +q being processed:

gmt begin map jpg+q95+m,pdf A,S
	gmt coast -RFR -JM6i -Gred -B
gmt end show

This means psconvert -Tj+quality can be used, as can gmt begin map jpg+q95.  This PR also documents that the default quality is 90.
@PaulWessel PaulWessel added enhancement Improving an existing feature new core module feature PR that implements a new core module feature labels Aug 1, 2021
@PaulWessel PaulWessel self-assigned this Aug 1, 2021
@maxrjones maxrjones added the add-changelog Add PR to the changelog label Aug 2, 2021
@PaulWessel PaulWessel merged commit cb0c144 into master Aug 2, 2021
@PaulWessel PaulWessel deleted the jpeg-quality-modifier branch August 2, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-changelog Add PR to the changelog enhancement Improving an existing feature new core module feature PR that implements a new core module feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants