Conversation
See #5348 for background and explanations. This PR implements those suggestions to make it simpler to select the unit or have no unit conversion on output, as well as improved documentation as to what is happening. Closes $5348.
Member
|
With the division it works. however, when I try MUL all the result were 1/2.54 or 1/2.542 Only when the units are in inches I get 1
|
Member
Author
|
Yes, and can't help that. If you specify units then GMT will convert them to inches. Now you have 1/2.54 inside. If you dont want that conversion, dont give units. |
Member
|
So, should I approve this feature, right? And then avoid using units? Maybe a warning message could be add in the docs. |
Member
Author
|
Give me a minute to update the docs and if you think they are clear then you can approve. |
Member
Author
|
Should now make it clear that using units on input gives internal INCHES, and if that is not desired then do not use units. See new section in man page called Scalar math with units. |
Esteban82
approved these changes
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5348 for background and explanations. This PR implements those suggestions to make it simpler to select the output unit or have no unit conversion on output, as well as improved documentation as to what is happening. Closes $5348.