Let colorbar handle CPTs with transparency#5328
Merged
PaulWessel merged 2 commits intomasterfrom Jun 12, 2021
Merged
Conversation
If the CPT has slices with transparency specified then we now honor that. For discrete CPTs you may have all or individual slices be transparent, while for continuous CPTs you must either have all or no slices be transparent. Closes #5326.
anbj
approved these changes
Jun 12, 2021
Contributor
anbj
left a comment
There was a problem hiding this comment.
In my specific use case, this seems to be working now.
Simply great!
maxrjones
approved these changes
Jun 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the CPT has slices with specified transparency then we now honor that. For discrete CPTs you may have all or individual slices be transparent, while for continuous CPTs you must either have all or no slices be transparent. The only case we are not handling is continuous CPTs with a section that implies a change in transparency. I added a test to demonstrate this capability:
Closes #5326.