The gmtlib_validate_id function stepped on another object's family#5100
Merged
PaulWessel merged 2 commits intomasterfrom Apr 5, 2021
Merged
The gmtlib_validate_id function stepped on another object's family#5100PaulWessel merged 2 commits intomasterfrom
PaulWessel merged 2 commits intomasterfrom
Conversation
Nasty business, such squabbles. The if-tests were incorrect and we ended up changing a grid objects type to dataset because its actual family was matrix. But that should only happen if the stated family is not grid nor image.
seisman
approved these changes
Apr 5, 2021
Member
seisman
left a comment
There was a problem hiding this comment.
I can confirm that it fixes GenericMappingTools/pygmt#1177
Member
Author
|
A small step for a man, a giant leap for ... |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How rude! Nasty business, such squabbles. The if-tests in gmtlib_validate_id were incorrect and we ended up changing a grid object's type to dataset because its actual family was matrix. But that should only happen if the stated family is neither grid nor image.
This PR should fix the PyGMT problem reported here; please check and then approve if fixed.