fix(website): genome viewer tries to fetch data from wrong location#1128
Merged
fengelniederhammer merged 1 commit intoApr 2, 2026
Merged
Conversation
Necessary due to the change in withastro/astro#15473
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
11fb567 to
2bef7bb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1083 where the genome viewer on genspectrum.org was attempting to fetch genome annotation data from https://localhost/... in production, by configuring Astro’s domain security settings so the app correctly trusts the externally served hostnames behind the proxy setup.
Changes:
- Added
security.allowedDomainsto the Astro configuration. - Whitelisted the two intended deployment hosts:
genspectrum.organdstaging.genspectrum.org.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chaoran-chen
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1083
Summary
See https://docs.astro.build/en/reference/configuration-reference/#securityalloweddomains
Setting
security.allowedDomainsfixes the issues together with https://github.com/GenSpectrum/servers/pull/473 (we didn't setX-Forwarded-Hostin the proxy config before). I think it makes sense to hardcode the value to the two hosts that we server the dashboards at.Screenshot
PR Checklist
- [ ] All necessary documentation has been adapted.- [ ] The implemented feature is covered by an appropriate test.