fix(db): apply abspath to logged path in _safe_url()#148
Conversation
Without this, _safe_url() could log a relative path while the actual connection uses the absolute one (resolved in _build_database_url).
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🐳 Dev images published!
The dev/test instance will pick up these changes automatically (Portainer GitOps). To test locally: docker pull drumsergio/telegram-archive:dev
docker pull drumsergio/telegram-archive-viewer:dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 94.06% 94.06%
=======================================
Files 21 21
Lines 6136 6137 +1
=======================================
+ Hits 5772 5773 +1
Misses 364 364
🚀 New features to boost your workflow:
|
Summary
os.path.abspath()to the path reconstructed in_safe_url()before logging, matching the same resolution done in_build_database_url()./backups/telegram_backup.db) would appear in logs while the actual DB connection uses the absolute pathFixes CodeRabbit review comment from PR #147.
Test plan
BACKUP_PATH