Skip to content

Comment out Add to Calendar code. Will rework this into a new block w…#987

Merged
mauteri merged 2 commits intodevelopfrom
add-to-calendar-disable
Jan 5, 2025
Merged

Comment out Add to Calendar code. Will rework this into a new block w…#987
mauteri merged 2 commits intodevelopfrom
add-to-calendar-disable

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Jan 5, 2025

…ith template.

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Jan 5, 2025

PR Summary

  • Improved Project Dependencies Management
    The dependencies in index.asset.php have been updated, with the removal of 'react-jsx-runtime' and 'wp-primitives'. This helps reduce bloated components and increase efficiency.

  • Hash Version Update
    The version hash in index.asset.php has been changed from 'ba5ac4ef32527b65cc60' to '37389dc4747e8e7e0953'. This reflects the implementation of the new changes and enhances the component's uniqueness.

  • Code Clean-up
    The block registration in index.js has been refactored, with the removal of commented-out code for both 'core/buttons' and 'core/details' variations. This makes the code easier to read and manage, improving workflow efficiency.

  • Block Registration Simplification
    The structure of the function used for registering block variations has been simplified and naming convention has been adjusted for clarity, improving comprehensibility and reducing effort during development and debugging.

  • Consistency in Data Processing
    The block registration logic has been combined, ensuring that the service data is consistently processed across functionalities. This merge helps in enhancing maintainability, reducing code redundancy and ensuring uniformity.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 5, 2025

Preview changes with Playground

You can preview the recent changes for PR#987 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit c1d0494 into develop Jan 5, 2025
@mauteri mauteri deleted the add-to-calendar-disable branch January 5, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant