Skip to content

a11y updates#972

Merged
mauteri merged 3 commits intodevelopfrom
render-block-updates
Dec 31, 2024
Merged

a11y updates#972
mauteri merged 3 commits intodevelopfrom
render-block-updates

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Dec 31, 2024

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Dec 31, 2024

PR Summary

  • Improvement in Accessibility
    Added a feature where the role attribute is set as 'button' for hyperlink tags in both the modal manager and RSVP classes. This makes it easier for screen readers to identify interactive elements, enhancing website accessibility.

  • Maintaining Expected Behavior
    Implemented checks to ensure that this role attribute as a 'button' is only assigned to anchor tags. This ensures that other types of tags will behave as expected, maintaining consistency and preventing any unexpected results.

@mauteri mauteri marked this pull request as ready for review December 31, 2024 20:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 31, 2024

Preview changes with Playground

You can preview the recent changes for PR#972 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit 0407b58 into develop Dec 31, 2024
@mauteri mauteri deleted the render-block-updates branch December 31, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mauteri