V2 for RSVP and RSVP Response blocks#959
Conversation
PR Summary
|
…ock implementation.
…ture/rsvp-block-variation
…d packages and make necessary adjustments.
Preview changes with PlaygroundYou can preview the recent changes for PR#959 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
| const { getEntityRecords } = select(coreStore); | ||
|
|
||
| const users = getEntityRecords('root', 'user', { | ||
| per_page: -1, |
There was a problem hiding this comment.
@mauteri Can we use something other than -1 here to avoid potential performance issues?
jmarx
left a comment
There was a problem hiding this comment.
Lett a non blocking comment. It all looks good to me.
Description of the Change
This is a complete rewrite of the RSVP and RSVP Response blocks (called V2 for now). The custom blocks are now block just wrapping blocks with core and custom blocks in a template. Interactivity API is being added for functionality that the custom React Block used to provide. The intent of this is to keep all/most of the functionality the previous blocks provided, but allow additional flexibility around styling and configuring these blocks. Some new blocks are being introduced like the Modal block and RSVP Status block since those blocks do not exist in core. The idea is to use core blocks wherever it is possible and makes sense (same with block variations) and create custom blocks when such a thing feels unnatural or confusing.
This is a huge PR since there is a lot of functionality that is contingent on other functionality. I don't love that this PR is so huge, but I plan to draw the line with MVP functionality of these blocks before creating new PRs to further enhance the blocks as we test.
At the end of all this, these blocks will be replacing the RSVP and RSVP Response blocks.
Closes #691 #589 #696 #934 #573
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: