Respect users locale and custom date- and time-formats in sent emails#922
Merged
mauteri merged 4 commits intoGatherPress:mainfrom Sep 26, 2024
Conversation
…e GatherPress filters for date- and time- format, as well as the users timezone, are recognized by the functions inside render_template().
Contributor
Preview changes with PlaygroundYou can preview the recent changes for PR#922 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
1 task
mauteri
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fragmentation of #752
Until this PR, sent emails dont respect the users locale nor her personal date- and time formatting settings.
Description of the Change
This PR fixes that, by:
render_template()Closes #How to test the Change
Testing this PR might be a little tricky and is not possible with WordPress Playground because of the necessary sending & receiving of emails.
Preparation to test:
profile.phpTesting this PR:
Changelog Entry
Credits
Props @carstingaxion
Checklist: