Allow special chars in user-defined date- and time-format strings#920
Merged
mauteri merged 1 commit intoGatherPress:mainfrom Sep 26, 2024
Conversation
Contributor
Preview changes with PlaygroundYou can preview the recent changes for PR#920 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
mauteri
approved these changes
Sep 26, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fragmentation of #752
In the gatherpress timeformat settings,
\are ok and allowed.While within the
profile.php, they are not and get stripped off on save.Description of the Change
This PR fixes that and allows to enter & save special chars into the custom datetime formatting settings.
Closes #How to test the Change
Try to save the German timeformat and check it is actually saved:
G:i \U\h\r,which is the same as saying
G:i o'clockChangelog Entry
Credits
Props @carstingaxion
Checklist: