Skip to content

Set html language attributes correctly for emails#919

Merged
mauteri merged 1 commit intoGatherPress:mainfrom
carstingaxion:fix/fragment-of-752-set-html-lang-attr
Sep 26, 2024
Merged

Set html language attributes correctly for emails#919
mauteri merged 1 commit intoGatherPress:mainfrom
carstingaxion:fix/fragment-of-752-set-html-lang-attr

Conversation

@carstingaxion
Copy link
Copy Markdown
Collaborator

@carstingaxion carstingaxion commented Sep 26, 2024

Fragmentation of #752

Description of the Change

Until this PR GatherPress sends email with a fixed language attribute of "en-us", which doesn't reflect the sites or users locale.

Closes #

How to test the Change

  1. Change your sites default language to anything else, than en_US.
  2. Send yourself an email via an event
  3. Check the html of the sent email for the lang-attribute on the html element.
  4. This should reflect your set language

Changelog Entry

Fixed - Set html language attributes correctly for emails

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions
Copy link
Copy Markdown
Contributor

Preview changes with Playground

You can preview the recent changes for PR#919 with the following PHP versions:

PHP Version 8.3

PHP Version 7.4

Download .zip with build changes

Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions.

@mauteri mauteri merged commit 3a1ee6b into GatherPress:main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants