Conditionally render the featured image in the email, only if it is set.#918
Merged
mauteri merged 1 commit intoGatherPress:mainfrom Sep 26, 2024
Conversation
Contributor
Preview changes with PlaygroundYou can preview the recent changes for PR#918 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
mauteri
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fragmentation of #752
Description of the Change
Until this PR GatherPress sends email including an img-tag, even if the event has no featured-image set.
Closes #How to test the Change
Send yourself an event-email, that has no image set and prove that thze received email doesn't contain an empty img-tag.
Changelog Entry
Credits
Props @carstingaxion
Checklist: