Merged
Conversation
…imum_supported_wp_version before
…ate 100%-core strings)
…(5) so that it is hidden by default
Contributor
Preview changes with PlaygroundYou can preview the recent changes for PR#897 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
mauteri
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled upon this error
after I removed a
// phpcs:ignore ...statement for the mentioned sniff. Curious about the 6.2 version, I started investigating and found that there were two minor syntax errors in one of the config rules.GatherPress tested itself against the minimum supported WordPress version of 7.4, what is ... let's say early.
Description of the Change
I fixed the wrong syntax, which made my mentioned error disappear correctly.
then I started adding some unrelated other things
Allowed to use the
'default'textdomain for strings that are 100%-sure part of core.Added a rule to alert with a warning on
@todocomments (Not quiet sure, if this is what we want, or if this makes more trouble)Added the
WordPress-Docsruleset to make sure everything is properly documented and prepare for an automated code-referenceCloses #How to test the Change
See the results of the test runner.
Changelog Entry
Credits
Props @carstingaxion
Checklist: