Skip to content

Fix block issues with FSE allowing block editing and causing errors.#871

Merged
mauteri merged 1 commit intomainfrom
mauteri-event-date
Sep 13, 2024
Merged

Fix block issues with FSE allowing block editing and causing errors.#871
mauteri merged 1 commit intomainfrom
mauteri-event-date

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Sep 13, 2024

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Sep 13, 2024

PR Summary

  • Version Number Updates in Asset Files
    We updated the version numbers for both blocks and assets. This means our Event Date Block, Online Event Block, Venue Block, and Panels Asset have all been upgraded to their respective latest versions.

  • Import Statement Modifications
    We refined the import statements in the scripts that edit our blocks - 'Event Date', 'Online Event', and 'Venue'. Specifically, we replaced the isSinglePostInEditor with isGatherPressPostType.

  • Logic Changes in Edit Components
    By using the new isGatherPressPostType method, the system will now decide what to show in the InspectorControls based on the type of GatherPress post. This promotes more efficient and accurate rendering.

  • Minor Update in DateTimeRange.js
    We made a small adjustment in 'DateTimeRange.js' to ensure safe access to 'gatherpress_datetime'. This even further optimizes the performance of our system.

  • Function Documentation Revision in globals.js
    The documentation in 'globals.js' was modified to reflect all these changes, ensuring that it provides clear and up-to-date information about our post type checks specific to GatherPress.

@github-actions
Copy link
Copy Markdown
Contributor

Preview changes with Playground

You can preview the least recent changes for PR#871 by following one of the links below:

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@mauteri mauteri marked this pull request as ready for review September 13, 2024 17:08
@mauteri mauteri merged commit 50d3b81 into main Sep 13, 2024
@mauteri mauteri deleted the mauteri-event-date branch September 13, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant