Use latest stable plugin version (not dev) to generate screenshots from#847
Merged
carstingaxion merged 2 commits intoGatherPress:mainfrom Sep 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots are made from released versions only
Running this workflow from an unpublished development release leads to 404s on all language packs
https://downloads.wordpress.org/translation/plugin/gatherpress/0.31.0-alpha/fr_FR.zip
Description of the Change
Thats why we grab the latest release directly from wp.org, which makes sure the existing translations will match the loaded codebase.
Alternatives
We could instantly rewrite the version numbers in .php and .md file to match the latest stable version.
This would allow
downloads.wordpress.org/translationto find and load the translation files. But it could be that parts of the plugin will not be translated or not be as accurate as on the last stable.#Closes an undocumented problem with the new wp-playground/cli powered screenshot generator.How to test the Change
Lets start the workflow and lets see if french UI, will be really french UI !
Changelog Entry
Credits
Props @carstingaxion
Checklist: