Skip to content

Migrate screenshot workflow to playground/cli (Attempt: 2)#838

Merged
mauteri merged 28 commits intoGatherPress:mainfrom
carstingaxion:try/migrate-screenshot-workflow-to-playground-cli-2
Sep 2, 2024
Merged

Migrate screenshot workflow to playground/cli (Attempt: 2)#838
mauteri merged 28 commits intoGatherPress:mainfrom
carstingaxion:try/migrate-screenshot-workflow-to-playground-cli-2

Conversation

@carstingaxion
Copy link
Copy Markdown
Collaborator

@carstingaxion carstingaxion commented Sep 2, 2024 •
edited
Loading

Description of the Change

Use WordPress Playground in favor of wp-env as the environment for the screenshot generator.

Switching to Playground not only makes this workflow a lot faster, it also allows to use a blueprint.json to setup the environment, which is way more comfortable, than writing a long list of wp-cli commands to do the same.

Needed before merge

Included in this PR is also:

  • the subtle change to use the modern Admin-UI,
    which should become the default across all GatherPress Playgrounds
  • hiding the admin-notices for this presentation-purpose, like @patriciabt suggested
  • fixing the left sided menu background to fill the full height of the screen

grafik

Closes #

How to test the Change

Changelog Entry

Changed - Run the screenshot generator workflow on WordPress Playground

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@carstingaxion
Migrate screenshot generator from wp-env to wp-playground/cli
f96d31b
@carstingaxion
Adjust styling in virtual browser to make left menu bar fill the full…
34dab25 
… heigt of the page
@carstingaxion
Re-Enable TEMP DISABLED pre-runner
f367af2
@carstingaxion
Add (WIP) documentation
a5684c4
@carstingaxion
Set site language dynamically per matrix and use a temp blueprint to …
0407074 
…start localized playgrounds
@carstingaxion
Clean up
ea5125b
@carstingaxion
Remove empty line from "run"
4c09747
@carstingaxion
TRY to simplify workflow to make it run again
ca29873
@carstingaxion
TRY Disableing node_modules cache
148446d
@carstingaxion
Remove superflous code
296bc9d
@carstingaxion
TRY following e2e tests config without a use declaration (feels weird…
8c24b0e 
…, but lets test)
@carstingaxion
Enable playwright webserver debugging
c55a749
@carstingaxion
Start the server via playwright (ssems to be more stable)
a603c87
@carstingaxion
Prevent a setSiteLanguage en_US step, as it'll fail
732a1a0
@carstingaxion
Decrease allowed max differences(, because the recreation should have…
ec5081e 
… been triggered on the last run)
@carstingaxion
Cleanup
8c0c47f
@carstingaxion
Set WPLANG option in addition to setSiteLanguage step
78f46b1
@carstingaxion
Setup Playground in a separate earlier step, to make sure it is loade…
49d5a09 
…d before the tests start
@carstingaxion
Run the next step after server setup
7c0b431
@carstingaxion
Fix "page" fixtures are not supported in "beforeAll"
4355f52
@carstingaxion
Allow to replace all existing images via workflow input
33f1e24
@carstingaxion
Simplify config
428f086
@carstingaxion
Cleanup
c50ddc6
@carstingaxion
Allow to replace all existing images via workflow input (2/2)
6b8bc0c
@carstingaxion
Remove pull_request from workflow triggers (WHICH WAS THERE FOR TESTI…
f6444c7 
…NG ONLY)
@carstingaxion
Update docs
4a2ae67
This was referenced Sep 2, 2024
Closed
Merged
@mauteri mauteri merged commit 1fad80a into GatherPress:main Sep 2, 2024
@carstingaxion carstingaxion mentioned this pull request Sep 3, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauteri mauteri mauteri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carstingaxion @mauteri