Hide Admin Notice about alpha-plugin, also if installed via the branch-named zip#808
Merged
mauteri merged 4 commits intoGatherPress:mainfrom Aug 16, 2024
Merged
Hide Admin Notice about alpha-plugin, also if installed via the branch-named zip#808mauteri merged 4 commits intoGatherPress:mainfrom
mauteri merged 4 commits intoGatherPress:mainfrom
Conversation
mauteri
reviewed
Aug 16, 2024
Contributor
Preview changes with PlaygroundYou can preview the least recent changes for PR#808 by following one of the links below: |
Collaborator
Author
|
Friendly ping @mauteri ;) |
mauteri
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a plugin from w.org would have a unigue slug to check against,
this is different for .zips downloaded from github.com.
A download via "<> Code ⏷" > "Download ZIP" will include the branch in the file name,
while a download via "Releases" will provide a zip without a branch name attached.
Description of the Change
This PR makes sure, that GatherPress checks against both possible slugs inside the condition to whether or not to show the admin notice about the alpha-plugin.
Closes #807
How to test the Change
Changelog Entry
Credits
Props @carstingaxion
Checklist: