Skip to content

Reflect changes to the venue term, when a venue post gets deleted.#731

Merged
mauteri merged 2 commits intoGatherPress:mainfrom
carstingaxion:fix/730
Jul 14, 2024
Merged

Reflect changes to the venue term, when a venue post gets deleted.#731
mauteri merged 2 commits intoGatherPress:mainfrom
carstingaxion:fix/730

Conversation

@carstingaxion
Copy link
Copy Markdown
Collaborator

@carstingaxion carstingaxion commented Jul 14, 2024

Description of the Change

Closes #730

How to test the Change

Changelog Entry

Fixed - The terms of the shadow taxonomy _gatherpress_venue were not deleted, when the corresponding gatherpress_venue posts were deleted

Credits

Props @carstingaxion, @mauteri

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Jul 14, 2024

PR Summary

  • Improved Venue Post Status Checking
    The code has been altered to better verify whether a specific venue-related post is either being published or removed from the system. This will result in more accurate tracking of venue posts, aiding in data organization and availability.

@carstingaxion carstingaxion requested a review from mauteri July 14, 2024 13:57
@mauteri
Copy link
Copy Markdown
Contributor

mauteri commented Jul 14, 2024

@carstingaxion added a small change to the logic to keep it one conditional check and updated unit test. Good find on this bug!!

@mauteri mauteri merged commit 7957f7b into GatherPress:main Jul 14, 2024
@carstingaxion
Copy link
Copy Markdown
Collaborator Author

Cool thing, you updated the test as well! Really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

venue terms are not deleted with venue posts

2 participants