Skip to content

Add URL encoding to 'Add to calendar' links#725

Merged
mauteri merged 5 commits intoGatherPress:mainfrom
carstingaxion:fix/724
Jul 12, 2024
Merged

Add URL encoding to 'Add to calendar' links#725
mauteri merged 5 commits intoGatherPress:mainfrom
carstingaxion:fix/724

Conversation

@carstingaxion
Copy link
Copy Markdown
Collaborator

@carstingaxion carstingaxion commented Jul 11, 2024 •
edited
Loading

Description of the Change

Bildschirmaufzeichnung.vom.11.07.2024.17.19.14.mp4

Closes #724

How to test the Change

  1. Create an event with an ampersand (for example) in the title
  2. Publish and view event.
  3. Choose any of the 'Add to calendar' options and open the new event in your calendar
  4. See that everything behind the special character is missing in place.

Changelog Entry

Fixed - "Add to calendar" links not working for events with special charcters in title, description or venue

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Jul 11, 2024

PR Summary

  • Improvement to get_google_calendar_link function
    The changes made in the function that gets the Google Calendar link now allow for the use of an array to manage query parameters. This makes the function easier to read and maintain.

  • Improvement to get_yahoo_calendar_link function
    Similar to the above change, modifications to the function that manages the Yahoo Calendar link now incorporate the use of an array for query parameters, improving its readability and overall ease of maintenance.

@carstingaxion carstingaxion self-assigned this Jul 11, 2024
@carstingaxion carstingaxion requested a review from mauteri July 11, 2024 17:19
@mauteri mauteri merged commit aa09301 into GatherPress:main Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauteri mauteri mauteri approved these changes

Assignees

@carstingaxion carstingaxion

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Add to calendar" not working for events with special charcters in title

2 participants

@carstingaxion @mauteri