Skip to content

Use comments table for RSVP instead of custom RSVP table.#692

Merged
mauteri merged 19 commits intomainfrom
GP-687
Jun 23, 2024
Merged

Use comments table for RSVP instead of custom RSVP table.#692
mauteri merged 19 commits intomainfrom
GP-687

Conversation

@mauteri
Copy link
Copy Markdown
Contributor

@mauteri mauteri commented Jun 14, 2024 •
edited
Loading

Description of the Change

This change utilizes the Comments table with a comment type of gatherpress_rsvp in WordPress instead of a custom RSVP table. It also adds code for a comment tax_query, which isn't used at the moment, but will likely come in handy soon. This requires an update to GatherPress Alpha to migrated old RSVPs in custom table to Comments table, then delete the custom table.

Closes #687

How to test the Change

  • RSVP should work as it always has, but RSVPs will now be stored in Comments table.
  • A custom taxonomy _gatherpress_rsvp_status is also being used for attending, not_attending, waiting_list
  • Old RSVPs should not appear and need to be migrated with a change in GatherPress Alpha plugin.

Changelog Entry

Changed - Existing functionality

Credits

Props @mauteri, @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Jun 14, 2024

PR Summary

  • Enhancement in User Email Utilization
    Temporarily incorporated a feature to gather and use user email information across various components of our platform.

  • Improved Comment Management
    Included a new code that fetches comments and either inserts them as new or updates the existing ones based on their presence.

@carstingaxion carstingaxion linked an issue Jun 14, 2024 that may be closed by this pull request
Make RSVPs a custom comment type #687
Closed
1 task
@mauteri mauteri changed the title Started work on switching to comments table for RSVP. Use comments table for RSVP instead of custom RSVP table. Jun 22, 2024
@mauteri mauteri marked this pull request as ready for review June 22, 2024 17:50
@MervinHernandez MervinHernandez mentioned this pull request Jun 22, 2024
Closed
1 task
stephenerdelyi
stephenerdelyi approved these changes Jun 22, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stephenerdelyi stephenerdelyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this by:

  • reviewing that my existing test events (with attendees previously) are no longer displaying upon checkout + build
  • signing up for a test event from the frontend
  • ensuring that user was recorded
  • added a test user under a different account
  • successfully deleted / managed users from the gutenberg backend

No unexpected results were produced as a result of these updates. Marking as approved, though we should plan to update alpha to migrate over the existing data 🎉

@mauteri mauteri merged commit 8e6d80c into main Jun 23, 2024
@mauteri mauteri deleted the GP-687 branch June 23, 2024 14:16
@carstingaxion carstingaxion mentioned this pull request Jun 24, 2024
Closed
1 task
@carstingaxion carstingaxion mentioned this pull request Aug 15, 2024
Open
1 task
@carstingaxion carstingaxion mentioned this pull request Aug 29, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmarx jmarx jmarx approved these changes

@stephenerdelyi stephenerdelyi stephenerdelyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make RSVPs a custom comment type

3 participants

@mauteri @jmarx @stephenerdelyi